fix(press): delta pressure calculation before adirs on #8648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
reviewed
May 6, 2024
fbw-common/src/wasm/systems/systems/src/air_conditioning/cabin_pressure_controller.rs
Outdated
Show resolved
Hide resolved
lukecologne
reviewed
May 7, 2024
fbw-common/src/wasm/systems/systems/src/air_conditioning/cabin_pressure_controller.rs
Outdated
Show resolved
Hide resolved
lukecologne
reviewed
May 16, 2024
lukecologne
approved these changes
May 17, 2024
|
Quality Assurance Trainee Report Discord: LunakisLeaks Testing Process:
Negatives: Testing Results: Conclusions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR fixes an issue with the pressurization system. When spawning at an airport high above sea level the delta pressure was not being calculated correctly and the safety valved opened (triggering the corresponding ECAM warning).
The pressurization system uses the outside static pressure from the ADIRS to calculate delta pressure. Before the system is powered, the delta P cannot be computed. Now before ADIRS power up, the ECAM system page shows "XX" for delta pressure, no warning comes on, and the safety valve does not open.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub): Commander Ga
Testing instructions
Spawn at an airport high above see level (KDEN for example). Before powering up the ADIRS, ensure the delta pressure is not shown on the ECAM (it shows "XX" as above). Observe the safety valve is closed and no warrning comes on.
When setting the ADIRS to align, after a few seconds the delta pressure indication comes on, and is 0.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.